Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting custom HTML templates #89

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

feeltheajf
Copy link
Contributor

@feeltheajf feeltheajf commented Nov 5, 2024

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Critical parts are tested automatically
  • Where possible E2E tests are implemented
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • Functionality of the acceptance criteria is checked manually on the dev system.

closes #88

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (524a649) to head (7f1cbf5).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
pkg/provider/identityprovider.go 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   47.36%   47.49%   +0.13%     
==========================================
  Files          21       21              
  Lines        1974     1979       +5     
==========================================
+ Hits          935      940       +5     
  Misses        981      981              
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hifabienne hifabienne requested review from stebenz and livio-a and removed request for stebenz November 11, 2024 10:35
@livio-a livio-a changed the title Allow setting custom HTML templates, closes #88 feat: allow setting custom HTML templates Nov 12, 2024
@livio-a livio-a merged commit f0e54ba into zitadel:main Nov 12, 2024
6 of 7 checks passed
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom HTML templates
2 participants