-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: authorization #269
feat: authorization #269
Conversation
BREAKING CHANGES: - remove pkg/api/middleware packages (Introspection middleware) - remove deprecated `WithKeyPath` client connection option
BREAKING CHANGES: NewClient functions require context.Context remove deprecated `WithKeyPath` client connection option
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #269 +/- ##
=======================================
Coverage ? 34.28%
=======================================
Files ? 5
Lines ? 105
Branches ? 0
=======================================
Hits ? 36
Misses ? 66
Partials ? 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Ran the http example locally and it runs smooth and clear :).
2 small comments.
return true | ||
} | ||
return errors.Is(e.err, t.err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoudn't we also implement the Unwrap
method so the underlying error can be retreived?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely... added it
go.mod
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are updating all the deps, perhaps we should also update the generator versions in the Dockerfile:
zitadel-go/build/zitadel/Dockerfile
Lines 18 to 23 in 745cff2
FROM ${BUILDARCH}-base AS base | |
ARG PROTOC_VERSION=3.18.0 | |
ARG PROTOC_ZIP=protoc-${PROTOC_VERSION}-linux-${PROTOC_ARCH}.zip | |
ARG GATEWAY_VERSION=2.18.0 | |
ARG VALIDATOR_VERSION=0.9.1 | |
ARG TAG_NAME=main |
zitadel-go/build/zitadel/Dockerfile
Lines 56 to 57 in 745cff2
RUN go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@v1.1.0 | |
RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.27.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to latest versions
🎉 This PR is included in version 2.2.0-next.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Starts the new version of the ZITADEL SDK, which will provide more flexibility and better UX by (re)implementing the authorization feature.
relates to zitadel/zitadel#5192
BREAKING CHANGES:
NewClient functions require context.Context
remove deprecated
WithKeyPath
client connection optionDefinition of Ready