Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] One app never shows on the "request icon" dialog #66

Closed
Donnnno opened this issue Dec 20, 2021 · 4 comments
Closed

[BUG] One app never shows on the "request icon" dialog #66

Donnnno opened this issue Dec 20, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@Donnnno
Copy link
Contributor

Donnnno commented Dec 20, 2021

Noticed this weird bug because people keep reporting this to me. You can find more about it in these two issues below:

From the Arcticons issues: Arcticons-Team/Arcticons#623
Delta has this too: Delta-Icons/android#345

@sarsamurmu sarsamurmu added the bug Something isn't working label Dec 20, 2021
@moertel
Copy link
Contributor

moertel commented Mar 20, 2022

FWIW, I had a look at this today and found the following:

  • The error only occurs when Premium Requests are disabled
  • It's consistently the first non-themed app (sorted by app name) that is missing

Steps to reproduce:

  1. Run CandyBar Dev with default settings in an emulator of your choice
  2. Open "Icon Requests" - make note of the first app in the list
  3. Set <bool name="enable_premium_request">false</bool>
  4. Run in the same emulator again
  5. Open "Icon Requests" - the app you saw previously now has disappeared
  6. Bonus: The number of apps reported as "missing" on the home page differs by 1 from the number of apps shown in the "Icon Request" list

@Donnnno
Copy link
Contributor Author

Donnnno commented Mar 22, 2022

Very nice that you decided to look into that!
What a very specific thing that causes it to happen tho…

@sarsamurmu
Copy link
Collaborator

Fixed in 3.14.0

@Donnnno
Copy link
Contributor Author

Donnnno commented May 8, 2022

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants