Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollView Animation not working. #1

Open
Amanida opened this issue Jun 29, 2017 · 1 comment
Open

ScrollView Animation not working. #1

Amanida opened this issue Jun 29, 2017 · 1 comment

Comments

@Amanida
Copy link

Amanida commented Jun 29, 2017

Thank you for awesome library, but animation is not working properly.
The default value of animation is NO.
I think the right default value is YES same as your Example project.

Line 91~94 in GoAutoSlideView.m

- (void)onTimerFired{
    CGPoint newOffset = CGPointMake(self.scrollView.contentOffset.x + CGRectGetWidth(self.bounds), self.scrollView.contentOffset.y);
    [self.scrollView setContentOffset:newOffset animated:NO];
}

It should be edited like
[self.scrollView setContentOffset:newOffset animated:YES];

@zjmdp
Copy link
Owner

zjmdp commented Jun 29, 2017

Thank you for your comment. I guess I disabled animation just for avoiding a weird problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants