Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circom-prover: simplify the rapidsnark dependencies #329

Open
vivianjeng opened this issue Feb 19, 2025 · 0 comments
Open

circom-prover: simplify the rapidsnark dependencies #329

vivianjeng opened this issue Feb 19, 2025 · 0 comments

Comments

@vivianjeng
Copy link
Collaborator

Problem

Now the circom-prover depends on ark-works zkey, and proving key structure
so even when using witnesscalc and rapidsnark, it converts from json string to ark-works types
and it depends on ark-works crates
e.g.

let proving_key = read_proving_key::<_, Bn254>(&mut reader)?;

Details

  1. Should we convert to string type like witnesscalc+rapidsnark?
  2. or still keep it like
    rapidsnark = [
    "rust-rapidsnark",
    "serde_json",
    "ark-bn254",
    "ark-ec",
    "ark-groth16",
    "ark-bls12-381", # TODO: remove this
    "ark-relations",
    "ark-poly",
    ]
@KimiWu123 KimiWu123 moved this to Current Milestone in Mopro Kanban Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Current Milestone
Development

No branches or pull requests

2 participants