Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustwitness: unify the interface with witnesscalc-adapter #346

Open
KimiWu123 opened this issue Feb 28, 2025 · 0 comments
Open

rustwitness: unify the interface with witnesscalc-adapter #346

KimiWu123 opened this issue Feb 28, 2025 · 0 comments
Assignees

Comments

@KimiWu123
Copy link
Collaborator

Currently the witness generation interface of rustwitness and witnesscalc-adapter are,

// rustwitness
type RustWitnessWtnsFn = fn(HashMap<String, Vec<BigInt>>) -> Vec<BigInt>;
// witnesscalc
type WitnesscalcWtnsFn = fn(&str) -> anyhow::Result<Vec<u8>>;

We should unitfy the interface of rustwitness to &str because it's more extendable and won't be limited by the input format (for example, zupass's input is a double array key:[[values],[values], ...] which can't fit in rustwitness).

@KimiWu123 KimiWu123 added this to the Milestone 1, 6-12 weeks milestone Feb 28, 2025
@KimiWu123 KimiWu123 moved this to Current Milestone in Mopro Kanban Mar 12, 2025
@KimiWu123 KimiWu123 moved this from Current Milestone to In progress in Mopro Kanban Mar 12, 2025
@KimiWu123 KimiWu123 self-assigned this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

1 participant