Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export uniffi #356

Open
vivianjeng opened this issue Mar 6, 2025 · 0 comments
Open

re-export uniffi #356

vivianjeng opened this issue Mar 6, 2025 · 0 comments

Comments

@vivianjeng
Copy link
Collaborator

Problem

Now the test e2e needs to import both mopro-ffi and uniffi to make it generate bindings

Details

We can simplify this by re-exporting uniffi in mopro-ffi
so the users can just use

[dependencies]
mopro-ffi = "0.1"

[build-dependencies]
mopro-ffi = "0.1"

instead of

[dependencies]
mopro-ffi = "0.1"
uniffi = "0.29"

[build-dependencies]
mopro-ffi = "0.1"
uniffi = { version = "0.29", features = ["build"]}

We can also make it optional
e.g.
user can choose to use the 2nd way if he wants to use specific version of uniffi
and use a feature flag uniffi to export the default uniffi version
or it becomes

[dependencies]
mopro-ffi = {version = "0.1", features = ["uniffi"]}

[build-dependencies]
mopro-ffi = {version = "0.1", features = ["uniffi"]}

Acceptance criteria

If the user removes uniffi dependencies, mopro-ffi can still generate bindings

@KimiWu123 KimiWu123 added this to the Milestone 1, 6-12 weeks milestone Mar 12, 2025
@KimiWu123 KimiWu123 moved this to Current Milestone in Mopro Kanban Mar 12, 2025
@KimiWu123 KimiWu123 removed this from the Milestone 1, 6-12 weeks milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Current Milestone
Development

No branches or pull requests

2 participants