Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-map-values: key order in the returned object is undeterministic #208

Open
kisstkondoros opened this issue Nov 21, 2024 · 0 comments · May be fixed by #209
Open

p-map-values: key order in the returned object is undeterministic #208

kisstkondoros opened this issue Nov 21, 2024 · 0 comments · May be fixed by #209

Comments

@kisstkondoros
Copy link

This method is used during the pack phase in pnpm.

As the key order is not guaranteed to be kept by it, the dependency order may be changed as a result, leading to non-reproducible builds.
kisstkondoros pushed a commit to kisstkondoros/packages that referenced this issue Nov 21, 2024
fix(p-map-values): Keep order of entries in pMapValue
5629ee6 
This method is used during the pack phase in pnpm.

As the key order is not guaranteed to be kept by it, the dependency order
may be changed as a result, leading to non-reproducible builds.

This fixes zkochan#208
@kisstkondoros kisstkondoros linked a pull request Nov 21, 2024 that will close this issue
Open
kisstkondoros pushed a commit to kisstkondoros/packages that referenced this issue Nov 21, 2024
fix(p-map-values): Keep order of entries in pMapValue
eb39a2b 
This method is used during the pack phase in pnpm.

As the key order is not guaranteed to be kept by it, the dependency order
may be changed as a result, leading to non-reproducible builds.

This fixes zkochan#208
kisstkondoros added a commit to kisstkondoros/packages that referenced this issue Nov 25, 2024
@kisstkondoros
fix(p-map-values): Keep order of entries in pMapValue
639da5a 
This method is used during the pack phase in pnpm.

As the key order is not guaranteed to be kept by it, the dependency order
may be changed as a result, leading to non-reproducible builds.

This fixes zkochan#208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(p-map-values): Keep order of entries in pMapValue kisstkondoros/packages
1 participant
@kisstkondoros