Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node fetch vulnerability #32

Closed
wants to merge 1 commit into from
Closed

fix node fetch vulnerability #32

wants to merge 1 commit into from

Conversation

okhiroyuki
Copy link

@okhiroyuki okhiroyuki commented Nov 3, 2020

Update isomorphic-fetch to eliminate a node-fetch vulnerability.

refs: #31

test

yarn test
yarn run v1.22.10
$ mocha


  English TTS
    ✓ Hello (101ms)
    ✓ hello
    ✓ hello world
    ✓ 123

  Long Characters
    ✓ English: 180 characters
    ✓ English: 200 characters
    ✓ English: 268 characters throw RangeError
    ✓ Chinese: 193 characters
    ✓ Chinese: 200 characters
    ✓ Chinese: 211 characters throw RangeError

  parameters
    ✓ text = null (566ms)
    ✓ text = '' (201ms)
    ✓ text = 123 (186ms)
    ✓ lang = null (191ms)
    ✓ lang = '' (198ms)
    ✓ lang = 123 (number) (193ms)
    ✓ speed = null (188ms)
    ✓ speed = '123' (226ms)
    ✓ timeout = 10 ms (too short to success)

  Chinese TTS
    ✓ 你好
    ✓ 你好世界
    ✓ 123


  22 passing (2s)

✨  Done in 4.75s.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.364% when pulling 7be0b40 on okhiroyuki:fix/node-fetch-vulnerability into b55689f on zlargon:master.

@zlargon
Copy link
Owner

zlargon commented Nov 9, 2020

@okhiroyuki, thanks for helping solve the vulnerability. The vulnerability issue has been fixed in the latest version 0.0.5.
Also, the test framework was changing from Mocha to Jest for better supporting with latest node version.
Thanks.

@zlargon zlargon closed this Nov 9, 2020
@okhiroyuki okhiroyuki deleted the fix/node-fetch-vulnerability branch November 9, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants