Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy String#at workaround #1019

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Legacy String#at workaround #1019

merged 2 commits into from
Dec 9, 2021

Conversation

zloirock
Copy link
Owner

@zloirock zloirock commented Dec 7, 2021

For a long time, modern String#at was not added because of the conflict with an obsolete proposal.

However, even now loading core-js with stage-0 proposals can break modern String#at.

We can't just remove this proposal before core-js@4 since it will break too many cases.

However, we can bring the obsolete String#at module semantics closer to the modern String#at for avoiding the most conflicts. It's mainly allowing negative indexes, but with saving multibyte semantic.

@zloirock zloirock merged commit 46cd568 into master Dec 9, 2021
@zloirock zloirock deleted the at branch December 9, 2021 08:45
@zloirock
Copy link
Owner Author

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant