-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EHAM doesn't work #754
Comments
Same problem here |
Same |
@erikquinn this fails in v3.1.0 due to a In v3.2.0 that has been addressed, however, this still fails from within the PositionModel.calculatePosition = (coordinates, referencePostion, magneticNorth) => {
if (!coordinates || !referencePostion || !magneticNorth) {
throw new TypeError('Invalid parameter. PositionModel.getPosition() requires coordinates, referencePostion ' +
'and magneticNorth as parameters');
}
// ... magneticNorth is being evaluated as falsey (magneticNorth = 0) thus, it throws. |
@DennisPlant @georgeenciu @willfrd The fix is in PR. When you have a minute, could you please take a look at the review app and make sure everything is in working order? https://atc-dev-pr-187.herokuapp.com/ |
Working, @n8rzz thanks for the fix! :) |
Glad to hear it! This fix will be included in the upcoming v3.2.0 release |
Resolved by #755. Closing. |
it just keeps loading? anyone have the same prolem?
The text was updated successfully, but these errors were encountered: