Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EHAM doesn't work #754

Closed
DennisPlant opened this issue Dec 11, 2016 · 7 comments
Closed

EHAM doesn't work #754

DennisPlant opened this issue Dec 11, 2016 · 7 comments

Comments

@DennisPlant
Copy link

it just keeps loading? anyone have the same prolem?

@georgeenciu
Copy link

Same problem here

@willfrd
Copy link
Contributor

willfrd commented Dec 11, 2016

Same

@n8rzz
Copy link
Contributor

n8rzz commented Dec 11, 2016

@erikquinn this fails in v3.1.0 due to a _comment key within the stars definition.

In v3.2.0 that has been addressed, however, this still fails from within the PositionModel.

PositionModel.calculatePosition = (coordinates, referencePostion, magneticNorth) => {
    if (!coordinates || !referencePostion || !magneticNorth) {
        throw new TypeError('Invalid parameter. PositionModel.getPosition() requires coordinates, referencePostion ' +
            'and magneticNorth as parameters');
    }

    // ...

magneticNorth is being evaluated as falsey (magneticNorth = 0) thus, it throws.

@n8rzz
Copy link
Contributor

n8rzz commented Dec 11, 2016

@DennisPlant @georgeenciu @willfrd The fix is in PR. When you have a minute, could you please take a look at the review app and make sure everything is in working order? https://atc-dev-pr-187.herokuapp.com/

@willfrd
Copy link
Contributor

willfrd commented Dec 11, 2016

Working, @n8rzz thanks for the fix! :)

@n8rzz
Copy link
Contributor

n8rzz commented Dec 11, 2016

:shipit:

Glad to hear it! This fix will be included in the upcoming v3.2.0 release

@erikquinn
Copy link
Collaborator

Resolved by #755. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants