Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/examples folder is out-of-date #423

Closed
phillip-stephens opened this issue Aug 16, 2024 · 0 comments · Fixed by #433
Closed

/examples folder is out-of-date #423

phillip-stephens opened this issue Aug 16, 2024 · 0 comments · Fixed by #433
Assignees
Labels

Comments

@phillip-stephens
Copy link
Contributor

With IPv6 being added, the requirement to give a Resolver a correct IP local address, name servers, etc was added. Without proper config, it will fatally error.

I didn't update the examples when I merged that in and they now do not work:

~/zdns/examples/single_lookup on  phillip/353-multiple-modules! ⌚ 15:46:48
$ go run simple.go 
FATA[0000] Error initializing resolver: invalid resolver config: must have at least one external IPv4 name server if IPv4 mode is enabled 
exit status 1


Should be a quick fix, but I'd like to add some sort of unit test or something that CI will fail if we break these, otherwise I know this'll happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant