Skip to content

Commit 47d2d94

Browse files
viankakrisnaTimer
authored andcommitted
Ensure workspaces key exists in parent package.json (facebook#3989)
* add default value for globPatterns without this, the latest alpha broke on start ``` /Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130 .reduce( ^ TypeError: Cannot read property 'reduce' of undefined at findPkgs (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:130:6) at getMonorepoPkgPaths (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:143:22) at Object.<anonymous> (/Users/adeviankakrisnafadlil/Projects/eurecah/node_modules/react-scripts/config/paths.js:155:55) at Module._compile (module.js:643:30) at Object.Module._extensions..js (module.js:654:10) at Module.load (module.js:556:32) at tryModuleLoad (module.js:499:12) at Function.Module._load (module.js:491:3) at Module.require (module.js:587:17) at require (internal/module.js:11:18) error Command failed with exit code 1. ``` * also check for pkgPatterns for null * Update paths.js
1 parent 03604a4 commit 47d2d94

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

packages/react-scripts/config/paths.js

+3
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,9 @@ const getMonorepoPkgPaths = () => {
140140
if (monoPkgPath) {
141141
// get monorepo config from yarn workspace
142142
const pkgPatterns = require(monoPkgPath).workspaces;
143+
if (pkgPatterns == null) {
144+
return [];
145+
}
143146
const pkgPaths = findPkgs(path.dirname(monoPkgPath), pkgPatterns);
144147
// only include monorepo pkgs if app itself is included in monorepo
145148
if (pkgPaths.indexOf(appDirectory) !== -1) {

0 commit comments

Comments
 (0)