Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: nice_view shield assumes battery, does not respect widget selection #2466

Open
Grazfather opened this issue Sep 7, 2024 · 0 comments
Open

bug: nice_view shield assumes battery, does not respect widget selection #2466

Grazfather opened this issue Sep 7, 2024 · 0 comments

Comments

@Grazfather
Copy link
Contributor

Grazfather commented Sep 7, 2024 •
edited
Loading

There are ifdefs for USB_DEVICE_STACK for example, but whether or not you are on a wired board, it tries to read battery status. This causes the build to fail since ZMK will not be built with the zmk_event_zmk_battery_state_changed function defined.

Two simple ways to avoid:

  1. Require some battery config in the shield's KConfig (CONFIG_ZMK_BATTERY_REPORTING maybe?)
  2. Wrap everything battery related with ifdefs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Grazfather