fix(ble): enforce maximum length for dynamic device name #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudongzheng
force-pushed
the
bt-dynamic-len-pr
branch
from
7ee610e to
2906ff2
Compare
xudongzheng
force-pushed
the
bt-dynamic-len-pr
branch
from
2906ff2 to
feb38e2
Compare
joelspadin
reviewed
Jan 23, 2025
| @@ -238,6 +238,11 @@ config BT_PERIPHERAL_PREF_LATENCY | |||
| config BT_PERIPHERAL_PREF_TIMEOUT | |||
| default 400 | |||
|
|
|||
| # The device name should be 16 characters or less so it fits within the | |||
| # advertising data. | |||
There was a problem hiding this comment.
Does this need to be configurable? The comment implies that the value should always be 16.
There was a problem hiding this comment.
Yes, the value should not be changed. I didn't calculate the value myself but it should be the maximum Bluetooth advertising payload length minus everything in zmk_ble_ad.
It's getting set here so bt_set_name() and zmk_ble_set_device_name() return an error if the length is exceeded.
petejohanson
approved these changes
Feb 26, 2025
nmunnich
pushed a commit
to nmunnich/zmk
that referenced
this pull request
Feb 27, 2025
nmunnich
pushed a commit
to nmunnich/zmk
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.