BENCH: Add requirements-bench.txt
file to list required package versions to reproduce benchmarks plots.
#115
Labels
documentation
Improvements or additions to documentation
good first issue
Good for newcomers
performance
Related to performance
I recently discovered that the
perfplot
package introduced breaking changes since version0.9.8
that truncate toint
any values toperfplot.bench
'sn_range
argument (see: nschloe/perfplot#153). This results in the scriptscripts/benchmark.py
hanging indefinitely after a while. This because one of the inputs ton_range
of perfplot is0.1
and theperfplot.bench
function truncates this value to0.0
which leads torandom_polyagamma
hanging whendisable_checks=True
since0.0
is not a valid value for theh
parameter. Even if we changedisable_checks=False
, it will not help for versions of perfplot > 0.9.6 since the script will raise an exception forh <= 0
. The sensible thing to do is to add arequirements-bench.txt
file inside thescripts
folder so that anyone running the benchmarks can reliably reproduce them. Something like the following should suffice:The text was updated successfully, but these errors were encountered: