Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not saved when editing custom sails / Black sails #16

Closed
LogiccccL opened this issue Dec 20, 2023 · 7 comments · Fixed by #29
Closed

Changes are not saved when editing custom sails / Black sails #16

LogiccccL opened this issue Dec 20, 2023 · 7 comments · Fixed by #29
Assignees
Labels
bug Something isn't working

Comments

@LogiccccL
Copy link

LogiccccL commented Dec 20, 2023

Certain options within the "Customize Sail" UI do not save and will revert back after a few seconds. For example, enabling "Allow raising sail" then hitting save will result in the sail rolling up as intended, but after a few seconds it will spring back down. When opening the UI again, the "Allow raising sail" option will be unchecked. However, other options (such as sail anchors) save just fine and remain saved indefinitely. In addition to this, sails will randomly turn completely black and remain that way until you relog/restart.

I have tested this on a singleplayer world, with no other mods installed (other than the dependencies BepIn and Jotunn) and on the latest version of both Valheim and this plugin.

Video showing both issues:
https://streamable.com/uz3n6q

@zolantris
Copy link
Owner

Do you have any error logs to attach. Also are you using vortex, thunderstorm or manual install?

Is the folder for the mod called ValheimRAFT or zolantris-ValheimRAFT?

@LogiccccL
Copy link
Author

I am using r2modman. The folder is named "zolantris-ValheimRAFT". The output log within BepInEx for the session where I recreated the issue contains no errors. I will attach the output log incase I missed something.
LogOutput.log

@zolantris
Copy link
Owner

The black sails issue is also not something I seen. Are you using vulkan by any chance?

@LogiccccL
Copy link
Author

I don't think so, launching the game via r2modman skips the typical steam popup asking whether to launch with vulkan or not. If you know a way I can check once the game has launched I can check for you.

@zolantris
Copy link
Owner

Typically you can find that in the player logs. https://steamcommunity.com/app/892970/discussions/1/4263206669438586409/

@zolantris
Copy link
Owner

Example for me on dx11 I see this log when launching the client.

[Physics::Module] Initialized MultithreadedJobDispatcher with 19 workers.
Initialize engine version: 2022.3.12f1 (4fe6e059c7ef)
[Subsystems] Discovering subsystems at path C:/Program Files (x86)/Steam/steamapps/common/Valheim/valheim_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1; jobified=0
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3090 Ti (ID=0x2203)
    Vendor:   NVIDIA
    VRAM:     24327 MB
    Driver:   31.0.15.4629
Begin MonoManager ReloadAssembly
- Loaded All Assemblies, in  0.052 seconds
- Finished resetting the current domain, in  0.001 seconds
<RI> Initializing input.

@zolantris zolantris added the bug Something isn't working label Dec 21, 2023
@zolantris zolantris self-assigned this Dec 21, 2023
@LogiccccL
Copy link
Author

It appears I am running on dx11 as well

[Physics::Module] Initialized MultithreadedJobDispatcher with 15 workers.
Initialize engine version: 2022.3.12f1 (4fe6e059c7ef)
[Subsystems] Discovering subsystems at path D:/Programs/Steam/steamapps/common/Valheim/valheim_Data/UnitySubsystems
GfxDevice: creating device client; threaded=1; jobified=0
Direct3D:
    Version:  Direct3D 11.0 [level 11.1]
    Renderer: NVIDIA GeForce RTX 3060 Ti (ID=0x2489)
    Vendor:   NVIDIA
    VRAM:     8038 MB
    Driver:   31.0.15.3623
Begin MonoManager ReloadAssembly
- Loaded All Assemblies, in  0.086 seconds
- Finished resetting the current domain, in  0.001 seconds
<RI> Initializing input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants