Request body as cache key issues

[vytas7]

It is quite unusual for GET or HEAD requests to have a non-empty body at all, but even for cached responders that do handle the request body, the stream would have been emptied and left at EOF if completely consumed.

Therefore, either would these responders interfere with the cache key logic, or the cache middleware would consume the stream leaving nothing for requests.

Ref:

falcon-caching/falcon_caching/middleware.py

Line 119 in 536faee

request_body = req.stream.read(req.content_length or 0)

[zoltan-fedor]

Thanks.
Yes, I was wondering about this part for a while, whether it is worth including or not.
Based on your insight regarding the emptied stream not being available for the request, it doesn't worth it, so for now I will just remove the request body from the cache key and leave only the path and the method.
If later a request comes up to include the request body, then I will reconsider how to include it while avoiding emptying the stream (maybe refill it?) or maybe by storing it on the req.context to make it available to the responder.

See 5591191