Handle nested controllers

[Intrepidd]

Welcome to the hype :)

This plug-in doesn't recursively look through controller folders.

If you do several imports it works but the definitions are not prefixed with the namespace as expected

How about adding resursive lookup of controllers?

[zombiezen]

Welcome to the hype :)

Thanks! Did I get linked somewhere? 😅

This plug-in doesn't recursively look through controller folders.

If you do several imports it works but the definitions are not prefixed with the namespace as expected

How about adding resursive lookup of controllers?

Hm, there is logic to recurse into subdirectories:

esbuild-plugin-stimulus/src/index.ts

Lines 53 to 60 in f8e57f9

	if (ent.isDirectory()) {
	result.push(...await walk(
	path.join(dir, ent.name),
	ent.name + '--',
	moduleDir + '/' + ent.name,
	));
	continue;
	}

Can you provide a Minimal, Reproducible Example of what you did and what isn't working for you?

[Intrepidd]

Thanks! Did I get linked somewhere? 😅

Not directly but with rails 7 embracing esbuild this plugin is gonna get some attention I'm sure :)

So realised the issue is that if there are 2 levels of recursion, the identifier ignores the first level of recursion.

Here is the repro : https://github.com/Intrepidd/esbuild-stimulus-issue

I have controller/directory1/directory2/baz_controller.js, but in the outfile, here is what I get :

  var definitions = [
    { identifier: "directory1--bar", controllerConstructor: bar_controller_default },
    { identifier: "directory2--baz", controllerConstructor: baz_controller_default },
    { identifier: "foo", controllerConstructor: foo_controller_default }
  ];

I have directory2--baz when I actually expect directory1--directory2--baz

I guess a naive fix would look like :

            result.push(...await walk(
              path.join(dir, ent.name),
              - ent.name + '--',
              + (prefix ? prefix + '--' : '') + ent.name + '--',
              moduleDir + '/' + ent.name,
            ));

So that the prefix is not reset for each recursive call

Thanks !

[Intrepidd]

Also _ is replaced by - which breaks the folder name, for instance :

foo_bar/some_controller.js will be foo_bar--some whereas it will be foo-bar--some with the existing @stimulus/webpack-helpers package