Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to EDNS or TCP can be in conflict with test cases #1071

Closed
matsduf opened this issue May 18, 2022 · 1 comment
Closed

Fallback to EDNS or TCP can be in conflict with test cases #1071

matsduf opened this issue May 18, 2022 · 1 comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented May 18, 2022

https://github.com/zonemaster/zonemaster-engine/blob/master/lib/Zonemaster/Engine/Profile.pm#L588-L597 says

resolver.defaults.fallback
A boolean. If true, UDP queries that get responses with the C
flag set will be automatically resent over TCP or using EDNS. Default
true.
In ldns-1.7.0 (NLnet Labs), in case of truncated answer when UDP is used,
the same query is resent with EDNS0 and TCP (if needed). If you
want the original answer (with TC bit set) and avoid this kind of
replay, set this flag to false.

I am not sure that this should be configurable here, since this can be in conflict with the test cases. It is probably more reasonable that it is set to false in the calls to LDNS, and then handled by the Zonemaster code.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label May 18, 2022
@matsduf matsduf added this to the v2022.2 milestone May 18, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Covered by a more general issue: #1148.

@tgreenx tgreenx closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Development

No branches or pull requests

2 participants