Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ADRs #4214

Closed
3 tasks done
eatyourgreens opened this issue Jan 29, 2023 · 3 comments · Fixed by #5863
Closed
3 tasks done

Missing ADRs #4214

eatyourgreens opened this issue Jan 29, 2023 · 3 comments · Fixed by #5863
Labels
documentation Add the documentation for something

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Jan 29, 2023

A few changes are missing decision records.

@eatyourgreens eatyourgreens self-assigned this Jan 29, 2023
@eatyourgreens eatyourgreens added the documentation Add the documentation for something label Jan 29, 2023
@goplayoutside3
Copy link
Contributor

Since this Issue is now a year old, I'm not sure ADRs on these subjects would be helpful. Static builds for the project pages is well documented in Next.js's docs.

@eatyourgreens I think you're most familiar with the second two points, and while there's no obligation to follow-up with ADR's, I'd like to know if I can close this Issue or if you plan to write them.

@eatyourgreens
Copy link
Contributor Author

Static builds for the project pages is well documented in Next.js's docs.

The Next.js docs won't tell you why Zooniverse switched from dynamic builds to static builds:

  • why dynamic builds were a problem for Zooniverse projects.
  • how static builds solved those problems.
  • what compromises were involved in that decision.

An ADR captures the context of a decision, so that it isn't lost.

These ADRs still seem helpful, based on questions I've been getting already about things that I've worked on. I might return to them, but I'm volunteering my unpaid time here so can't commit to anything definite.

@eatyourgreens
Copy link
Contributor Author

I wrote a quick ADR, in #5827, to explain the decision to remove Webpack builds in an ESM world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add the documentation for something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants