-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-build no longer works after installing bootsplash - expo SDK51 #610
Comments
@AyoCodess Publish your |
{
"name": "mobile",
"version": "0.0.1062",
"updateVersion": "13",
"main": "index.js",
"scripts": {
"start": "npm run cds && npx expo start -c --dev-client",
"device-i": "npm run cds && npx expo run:ios --device",
"device-a": "npm run cds && npx expo run:android --device",
"prebuild-i": "npm run cds && npx expo prebuild --clean -p ios",
"prebuild-a": "npm run cds && npx expo prebuild --clean -p android",
"prebuild": "npx expo prebuild --clean",
"create-d": "eas device:create",
"and": "expo run:android",
"ios": "expo run:ios",
"android": "expo run:android",
"patch": "patch-package"
},
"dependencies": {
"@clerk/clerk-expo": "^1.2.7",
"@codler/react-native-keyboard-aware-scroll-view": "^2.0.1",
"@expo/config": "~9.0.0",
"@gorhom/bottom-sheet": "^4.6.3",
"@hookform/resolvers": "^3.3.3",
"@react-native-async-storage/async-storage": "1.23.1",
"@react-native-community/datetimepicker": "8.0.1",
"@react-native-community/slider": "4.5.2",
"@react-native-picker/picker": "2.7.5",
"@repo/api": "*",
"@sentry/react-native": "~5.22.0",
"@shopify/flash-list": "1.6.4",
"class-variance-authority": "^0.7.0",
"dayjs": "^1.11.10",
"expo": "^51.0.20",
"expo-application": "~5.9.1",
"expo-build-properties": "~0.12.3",
"expo-checkbox": "~3.0.0",
"expo-clipboard": "~6.0.3",
"expo-constants": "~16.0.2",
"expo-crypto": "~13.0.2",
"expo-device": "~6.0.2",
"expo-file-system": "~17.0.1",
"expo-font": "~12.0.8",
"expo-linear-gradient": "^13.0.2",
"expo-linking": "~6.3.1",
"expo-local-authentication": "~14.0.1",
"expo-localization": "~15.0.3",
"expo-router": "=3.5.16",
"expo-secure-store": "~13.0.2",
"expo-sharing": "~12.0.1",
"expo-status-bar": "~1.12.1",
"expo-updates": "~0.25.19",
"expo-web-browser": "~13.0.3",
"lottie-react-native": "6.7.0",
"moti": "^0.29.0",
"nativewind": "^4.0.36",
"posthog-react-native": "^3.1.2",
"react": "18.2.0",
"react-hook-form": "^7.49.2",
"react-native": "0.74.5",
"react-native-bootsplash": "^6.1.1",
"react-native-circular-progress": "^1.3.9",
"react-native-circular-progress-indicator": "^4.4.2",
"react-native-gesture-handler": "~2.16.1",
"react-native-get-random-values": "~1.11.0",
"react-native-gifted-charts": "^1.4.9",
"react-native-haptic-feedback": "^2.2.0",
"react-native-modal": "^13.0.1",
"react-native-modal-datetime-picker": "^17.1.0",
"react-native-onboard": "^2.6.0",
"react-native-pager-view": "6.3.0",
"react-native-progress": "^5.0.1",
"react-native-reanimated": "~3.10.1",
"react-native-reanimated-carousel": "^3.5.1",
"react-native-safe-area-context": "4.10.5",
"react-native-screens": "3.31.1",
"react-native-select-dropdown": "^4.0.1",
"react-native-svg": "15.2.0",
"react-native-tab-view": "^3.5.2",
"react-native-toast-message": "^2.2.0",
"tailwindcss": "^3.4.3",
"zod": "^3.23.4",
"zustand": "^4.5.2"
},
"devDependencies": {
"@babel/core": "^7.20.0",
"@biomejs/biome": "1.8.3",
"@expo/config-plugins": "~8.0.0",
"@repo/typescript-config": "*",
"@types/node": "^20.11.19",
"@types/react": "~18.2.14",
"@types/react-native-get-random-values": "^1.8.2",
"expo-dev-client": "^4.0.15",
"patch-package": "^8.0.0",
"tailwind": "^4.0.0",
"typescript": "~5.3.3"
},
"expo": {
"autolinking": {
"exclude": [
"expo-splash-screen"
]
},
"private": true
}
} app config import type { ExpoConfig } from "@expo/config";
import { theme } from "./rawTheme";
const packageJson = require("./package.json");
const defineConfig = (): ExpoConfig => ({
name: getAppName(),
slug: "honeyroots",
scheme: "honeyroots",
orientation: "portrait",
icon: "./assets/icon.png",
userInterfaceStyle: "light",
version: packageJson.version,
experiments: {
typedRoutes: true,
},
assetBundlePatterns: ["**/*"],
ios: {
supportsTablet: true,
bundleIdentifier: getBundleId(),
config: {
usesNonExemptEncryption: false,
},
infoPlist: {
UIBackgroundModes: ["fetch", "remote-notification"],
NSFaceIDUsageDescription: "Allow HoneyRoots to use Face ID.",
},
},
android: {
adaptiveIcon: {
foregroundImage: "./assets/adaptive-icon.png",
backgroundColor: theme.raw.colors.primary,
},
permissions: [],
package: getBundleId(),
googleServicesFile:
process.env.GOOGLE_SERVICES_JSON ?? "./google-services.json",
},
web: {
favicon: "./assets/favicon.png",
},
extra: {
eas: {
projectId: "bggreeg",
},
supportsRTL: true,
},
owner: "ayocodes",
updates: {
url: "https://u.expo.dev/bgregd",
},
runtimeVersion: {
policy: "appVersion",
},
plugins: [
[
"expo-build-properties",
{
ios: {
newArchEnabled: false,
},
android: {
newArchEnabled: false,
},
},
],
["expo-router"],
[
"expo-updates",
{
username: "ayocodes",
enabled: true,
},
],
[
"expo-local-authentication",
{
faceIDPermission: "Allow $(The HoneyRoots App) to use Face ID.",
},
],
["expo-font"],
[
"@sentry/react-native/expo",
{
url: "https://sentry.io/",
note: process.env.SENTRY_AUTH_TOKEN ?? "sentry auth token error",
project: "honeyroots-app",
organization: "honeyroots",
},
],
["expo-localization"],
["react-native-bootsplash", { assetsDir: "assets/bootsplash" }],
],
});
export default defineConfig; |
Nothing wrong here. I tried to reproduce with an identical expo version, but everything went well, the directories are correctly created. Try isolate the issue and publish a minimal repository. |
Im working within a monorepo setup but i can't see why that would cause an issue. |
as soon i remove the plugin from my app config, prebuild works.
|
The issue could indeed come from the monorepo, as Try generating the assets at your project root. Where |
You was right! I ran the command at the root and generated the files. Thank you 👍🏾 |
@zoontek i'm running into a weird issue, when ever i run this command for both ios and android
my app builds and runs on my simulators just fine but when ever i want to build my apps locally to upload to the app stores manually with these commands
i get these errors ios
ANDROID
i tried EAS cloud, same error same errors i got before with prebuild. Any ideas? |
The Expo documentation really needs to be fixed here, as having let's say |
dayuuuuum... Thanks again. |
Thanks for the heads up! |
@AyoCodess Actually, I saw that this has been merged / fixed. Fortunately |
I have randomly started facing this issue as well. Everything is done according to the document and even removed android/ from .gitignore file. Prebuild started failing with the same error as above. I'm not using monorepo as well. EDIT: The issue occurs if there is no native project at all. UPDATE: It was an issue on my end. It removed the assets/bootsplash/android directory when I added android to .gitignore. The problem is fixed now. |
I had the issue too in my monorepo, only on EAS ; turned out /assets folders were gitignored at the repo // assets gitignored
|_ ts-pnpm-turborepo // needed to add here asset not gitignored, as EAS runs here ✅
|_ my-apps // asset not gitignored |
Before submitting a new issue
Bug summary
command used:
npx react-native generate-bootsplash assets/icon.png --platforms=android,ios --background=F5FCFF --logo-width=100 --assets-output=assets/bootsplash --flavor=main
i have followed all other instructions...
package json
"expo": { "autolinking": { "exclude": [ "expo-splash-screen" ] } }
app config:
["react-native-bootsplash", { assetsDir: "assets/bootsplash" }],
Resuts when running prebuild
IOS
ANDROID:
the CLi does not generate the ios and android files within the /bootsplash folder.
Library version
6.1.1
Environment info
Steps to reproduce
Reproducible sample code
The text was updated successfully, but these errors were encountered: