Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Clip apps & react-native-bootsplash not setting up properly #626

Open
3 tasks done
sgumz opened this issue Sep 5, 2024 · 5 comments
Open
3 tasks done

Apple Clip apps & react-native-bootsplash not setting up properly #626

sgumz opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@sgumz
Copy link

sgumz commented Sep 5, 2024

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

Apple Clips (https://www.npmjs.com/package/react-native-app-clip) works well with the traditional Expo Splash Screen. However, using React Native Bootsplash, the Clip app totally lost all expected configurations, including the traditional expo settings.

I observed that the BootSplash assets are correctly generated and added to the main and clip apps. However, the clip app is not used/started with that. Instead, it uses the traditional default expo-splash-screen settings. Works as expected in the main app.

Screenshot 2024-09-06 at 08 42 34@2x

Library version

6.1.3

Environment info

new project: last version of expo, react native

Steps to reproduce

  1. simple new expo project
  2. add react-native-app-clip pack
  3. add react-native-bootsplash
  4. generate new assets
  5. run npx expo prebuild --clean -p ios
  6. open project, and run the Clip app in the simulator

Reproducible sample code

{
  "name": "my-app",
  "main": "expo-router/entry",
  "version": "1.0.0",
  "scripts": {
    "start": "expo start",
    "reset-project": "node ./scripts/reset-project.js",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "web": "expo start --web",
    "test": "jest --watchAll",
    "lint": "expo lint"
  },
  "jest": {
    "preset": "jest-expo"
  },
  "expo": {
    "autolinking": {
      "exclude": [
        "expo-splash-screen"
      ]
    }
  },
  "dependencies": {
    "@expo/vector-icons": "^14.0.2",
    "@react-navigation/native": "^6.0.2",
    "expo": "~51.0.28",
    "expo-constants": "~16.0.2",
    "expo-font": "~12.0.9",
    "expo-linking": "~6.3.1",
    "expo-router": "~3.5.23",
    "expo-splash-screen": "~0.27.5",
    "expo-status-bar": "~1.12.1",
    "expo-system-ui": "~3.0.7",
    "expo-web-browser": "~13.0.3",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-native": "0.74.5",
    "react-native-app-clip": "^0.3.1",
    "react-native-bootsplash": "^6.1.3",
    "react-native-gesture-handler": "~2.16.1",
    "react-native-reanimated": "~3.10.1",
    "react-native-safe-area-context": "4.10.5",
    "react-native-screens": "3.31.1",
    "react-native-web": "~0.19.10"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@types/jest": "^29.5.12",
    "@types/react": "~18.2.45",
    "@types/react-test-renderer": "^18.0.7",
    "jest": "^29.2.1",
    "jest-expo": "~51.0.3",
    "react-test-renderer": "18.2.0",
    "typescript": "~5.3.3"
  },
  "private": true
}
@sgumz sgumz added the bug Something isn't working label Sep 5, 2024
@zoontek
Copy link
Owner

zoontek commented Sep 6, 2024

@sgumz Could be nice to inform the expo team about it too.

@zoontek
Copy link
Owner

zoontek commented Sep 6, 2024

@sgumz
Copy link
Author

sgumz commented Sep 7, 2024

I did a couple of tests but no success so far.

I added the test project here so you can easily copy it and play it on your side once you have a chance.

https://github.com/sgumz/testing-splash

Screenshot 2024-09-07 at 14 15 34@2x

^^^ this is a copy including the code at expo.plugins

      ["react-native-bootsplash", {
        "assetsDir": "assets/bootsplash"
      }]

Screenshot 2024-09-07 at 14 18 27@2x

^^ and here if I remove it: using the traditional expo splash screen

@zoontek
Copy link
Owner

zoontek commented Nov 12, 2024

@sgumz I'm waiting for Expo 52 / the new version of expo-splash-screen that will work exactly like react-native-bootsplash (using customizeRootView). There's a high chance that this will be fixed on their side.

@zoontek
Copy link
Owner

zoontek commented Nov 25, 2024

@sgumz Did you tried with Expo 52?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants