Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "app languages" on Android #245

Open
abejfehr opened this issue Feb 1, 2024 · 5 comments
Open

Add support for "app languages" on Android #245

abejfehr opened this issue Feb 1, 2024 · 5 comments
Assignees
Labels
feature request New feature or request Fund Can be funded on Polar.sh

Comments

@abejfehr
Copy link

abejfehr commented Feb 1, 2024

Why it is needed?

It's nice to be able to choose a language on a per-app basis instead of setting the whole OS, and it looks like that's possible now on Android: https://developer.android.com/guide/topics/resources/app-languages

Possible implementation

No response

Code sample

No response

Upvote & Fund

  • This repository is using Polar.sh so you can help prioritize & fund this issue.
  • The funding will only be unlocked once this issue is completed.
Fund with Polar
@abejfehr abejfehr added the feature request New feature or request label Feb 1, 2024
@zoontek
Copy link
Owner

zoontek commented Feb 1, 2024

@abejfehr It's already supported. Android now allow the user to overrides the app language in app settings and it updates what's returned by existing react-native-localize functions.

EDIT: Hmmm, I forget Android API are often stupidly designed. Will investigate on extras setApplicationLocales() and getApplicationLocales(). But if this allow overriding from the app directly, this is a terrible feature for user experience.

@itsramiel
Copy link

itsramiel commented Oct 25, 2024

EDIT: Hmmm, I forget Android API are often stupidly designed. Will investigate on extras setApplicationLocales() and getApplicationLocales(). But if this allow overriding from the app directly, this is a terrible feature for user experience.

What is your opinion on this @zoontek ?

The android apis make it just so that you dont have to go to the settings to change the per app language. From the linked guide:

If you use the public APIs for your in-app language picker, the device's system settings are automatically updated to match whichever language the user selects through your in-app experience.

These APIs automatically sync with system settings; therefore, apps that use these APIs to create custom in-app language pickers will ensure their users have a consistent user experience regardless of where they select their language preferences

@zoontek
Copy link
Owner

zoontek commented Oct 25, 2024

@itsramiel This does not seems like a lot of work, but it's very low-priority for me at the moment. Let’s place a small bid on it and see if companies have a real appetite for it.

@polar-sh polar-sh bot added the Fund Can be funded on Polar.sh label Oct 25, 2024
Copy link
Owner

zoontek commented Oct 25, 2024

You can now pledge behind and help support this effort using Polar.sh:

Fund with Polar

@itsramiel itsramiel mentioned this issue Oct 30, 2024
3 tasks
@davenewton069

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fund Can be funded on Polar.sh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants