zope.browserpage.metaconfigure.simple breaks subpaths

[vincg]

I'm currently in the process of porting a Zope2 project to Zope4, which worked surprisingly well so far. One big issue I've come across though is that our subpaths are broken, due to the simple-Class overriding our own publishTraverse and always returning NotFound.

our implementation

@implementer(IPublishTraverse)
class BaseSubPathView(object):
    def __init__(self, *a, **k): [...]
    def publishTraverse(self, request, name): [...]
    def __call__(self): [...]

and in zope.browserpage.metaconfigure

@implementer(IBrowserPublisher)
class simple(BrowserView):
 
    def publishTraverse(self, request, name):
        raise NotFound(self, name, request)

    def __call__(self, *w, **k): [...]

This does not work anymore because simple.publishTraverse is used, not BaseSubPathView.publishTraverse ... I patched this locally to the following:

@implementer(IBrowserPublisher)
class simple(BrowserView):

    def publishTraverse(self, request, name):
        # check if this method was overridden somewhere down the mro
        for c in self.__class__.__mro__[1:]:
            meth = getattr(c, 'publishTraverse', None)
            if meth is not None:
                return meth(self, request, name)
        raise NotFound(self, name, request)

    def __call__(self, *w, **k): [...]

[icemac]

zope.browserpage is also used outside Zope 4, so I'd rather like to fix this issue over there. See zopefoundation/Zope#610 for a PR which is work in progress.

[icemac]

@vincg Does #7 fix your problem?

[icemac]

#7 is released in version 4.4.0 on PyPI.

[vincg]

@icemac looks good! thanks for letting me know!

[icemac]

According to @vincg fixed via #7.

[vincg]

It seems I was a bit hasty in testing this. I did install it in the right virtualenv and followed our manual testcase and it worked, yet it did not verify the updated package was actually being used.

so it does not work yet. maybe this can be fixed in our code, I'm not sure and have to do more research, since this part of our application is rather old and the original dev is not with us anymore. I'm going to go into more detail on our subpathview, if that helps.

@implementer(IPublishTraverse)
class BaseSubPathView(object):

    def __init__(self, *args, **kw):
        self.subpaths = {}
        self._called_sub_path = None
        # find subpaths and bild up lookup
        for m_name, m in inspect.getmembers(self, predicate=inspect.ismethod):
            if hasattr(m, '_sub_path_name'):
                self.subpaths[m._sub_path_name] = m

    def publishTraverse(self, request, name):
        ''' Lookup for subpath
            (zope.publisher.interfaces.IPublishTraverse)
        '''
        log.debug('sub traverse %s' % name)
        if name in self.subpaths:
            self._called_sub_path = self.subpaths[name]
            return self
        return request.response.notFoundError(name)

    def __call__(self):
        csp = self._called_sub_path
        return csp() if csp else None

[icemac]

Are there any news on this issue?

[vincg]

from "our" side I don't know, I don't work for this company anymore, but my guess is my "patch" is still in use and it's not a priority as long as it works