-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider interface #7
Comments
What do you mean by only wanting to set the scope column? I do support the idea of making set_order/2 take options as opposed to multiple different arity functions regardless. |
Sorry that wasn't super clear. Right now I use the default fields for |
@mootpointer we do the same thing :). I like the idea of making the arguments to set_order just a changeset and opts, with default values. The defaults being |
At the moment the interface for setting the ranking column is a
set_order/4
which is fine, but makes things inconvenient if you only want to set the scope column (which is something I've done in Zova's implementation).So, perhaps
set_order/2
with a keyword list of options is more appropriate.To continue along that line, then maybe a
__using__
macro would make sense to push that config out of the normal flow.The text was updated successfully, but these errors were encountered: