Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ZOWE_EXPLORER_FRAME_ANCESTORS undefined command line param #44

Open
NakulManchanda opened this issue Aug 17, 2020 · 2 comments
Open
Milestone

Comments

@NakulManchanda
Copy link
Member

NakulManchanda commented Aug 17, 2020

Issue has been reported by customers, when upgrdaded from 1.11 to 1.12 by applying PTF update, and if data changes are not applied manually, then user received following message in logs:

failed to process config                                           
TypeError: config.csp.frame-ancestorsÝ0¨.split is not a function   

This message is written by all three explorers as we are unable to start them.
Reason being we introduced new property
ZOWE_EXPLORER_FRAME_ANCESTORS in 1.12
This property is required to be present in instance.env with some valid value,
when undefined it is treated as boolean, which breaks the build.
It breaks when we try to call split function of strings on boolean value during explorer-ui-server startup

@NakulManchanda
Copy link
Member Author

@NakulManchanda
Copy link
Member Author

@jordanCain i will apply following changes and send PR for review
so solution is:

  • handle undefined better in server
  • but also adding ZOWE_EXPLORER_FRAME_ANCESTORS to start.sh of explorers if undefined/missing in instance.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants