Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect floating promises with ESLint #2291

Closed
t1m0thyj opened this issue May 17, 2023 · 1 comment · Fixed by #2292
Closed

Detect floating promises with ESLint #2291

t1m0thyj opened this issue May 17, 2023 · 1 comment · Fixed by #2292
Assignees
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits Technical Debt Includes Architecture, Code, Testing, Automation debt
Milestone

Comments

@t1m0thyj
Copy link
Member

As a Zowe Explorer developer,
I want to eliminate floating promises from our code base,
to prevent uncaught promised exceptions which are difficult to debug.

@t1m0thyj t1m0thyj added enhancement New feature or request Technical Debt Includes Architecture, Code, Testing, Automation debt priority-medium Not functioning - next quarter if capacity permits labels May 17, 2023
@t1m0thyj t1m0thyj self-assigned this May 17, 2023
@t1m0thyj
Copy link
Member Author

t1m0thyj commented May 17, 2023

Discussed with @traeok and originally we deliberately disabled the @typescript-eslint/no-floating-promises for our codebase because it caused a number of false positives around Thenables used by VS Code API methods like vscode.window.showInformationMessage.

Perhaps we could add a customized version of the no-floating-promises rule to our ESLint plugin that enforces the rule only for promises that implement a .catch method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium Not functioning - next quarter if capacity permits Technical Debt Includes Architecture, Code, Testing, Automation debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants