Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Standardize response output from all SDK methods #266

Closed
zFernand0 opened this issue May 23, 2024 · 1 comment · Fixed by #285
Closed

[chore]: Standardize response output from all SDK methods #266

zFernand0 opened this issue May 23, 2024 · 1 comment · Fixed by #285
Assignees
Labels
Milestone

Comments

@zFernand0
Copy link
Member

Describe the bug

Throughout the codebase, we have a few methods that return the entire object from the REST request, and users have to get the result["response"] in order to get to the JSON properties of the response object.

Expected and actual results

We should return the response object (which contains the JSON properties) instead of the REST response object

Describe your environment

N/A

Additional context

Here is a good way to identify the methods that are not complying with this rule: (thanks @t1m0thyj)

@zFernand0 zFernand0 added bug Something isn't working priority-medium labels May 23, 2024
@zFernand0 zFernand0 added this to the v1 LTS milestone May 23, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad May 23, 2024
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@zowe-robot zowe-robot moved this from New Issues to Medium Priority in Zowe CLI Squad May 23, 2024
@zFernand0 zFernand0 changed the title Standardize response output from all SDK methods [chore]: Standardize response output from all SDK methods May 23, 2024
@pem70 pem70 self-assigned this Jun 7, 2024
This was referenced Jun 10, 2024
@zFernand0 zFernand0 linked a pull request Jun 11, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Medium Priority to Closed in Zowe CLI Squad Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants