Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the use of Eigen in the GPU kernel code #115

Open
zpzim opened this issue Jun 14, 2022 · 1 comment
Open

Evaluate the use of Eigen in the GPU kernel code #115

zpzim opened this issue Jun 14, 2022 · 1 comment
Labels
cleanup Cleanup task enhancement New feature or request performance

Comments

@zpzim
Copy link
Owner

zpzim commented Jun 14, 2022

Eigen has worked well with the CPU kernels. We can also rewrite the GPU code to try and use it. This will simplify the GPU kernels which are quite messy right now and potentially improve performance.

@zpzim zpzim added cleanup Cleanup task enhancement New feature or request performance labels Jun 14, 2022
@zpzim
Copy link
Owner Author

zpzim commented Aug 1, 2022

I have cleaned up the GPU code using Eigen. The code is sitting on the use-eigen-in-gpu-kernels branch.

In this cleanup, I removed the mixed precision mode from the GPU kernels, it wasn't improving performance over double precision and as a result provided little-to-no benefit. Mixed precision will be deprecated and just use the double precision functionality from now on.

I have only tested these changes on P100; there are a few more steps I need to take to make sure these changes don't affect performance on other GPUs. Before merging, I will do some parameter tuning for K80, V100, A100, and Geforce 3080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup task enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

1 participant