-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Cb atoms of threonines, perhaps other amino-acids? #4
Comments
I have also noticed this not just on Maestro but also PyMOL. My observations:
$ neuralplexer-inference --task=batched_structure_sampling \
--input-receptor input/protein.pdb \
--input-ligand input/lig.sdf \
--use-template \
--input-template input/protein.pdb \
--out-path output \
--model-checkpoint ${nplx_data_dir}/complex_structure_prediction.ckpt \
--n-samples 16 \
--chunk-size 4 \
--num-steps=40 \
--cuda \
--sampler=langevin_simulated_annealing
$ neuralplexer-inference --task=batched_structure_sampling \
--input-receptor input/protein.pdb \
--input-ligand input/lig.sdf \
--out-path output \
--model-checkpoint ${nplx_data_dir}/complex_structure_prediction.ckpt \
--n-samples 16 \
--chunk-size 4 \
--num-steps=40 \
--cuda \
--sampler=langevin_simulated_annealing
|
I reviewed your output files and it looks like the model collapses Ca and Cb atoms for these amino acids, which prevents PyMol from properly visualizing them. Not sure if this is a typo in the code or in the actual output of the model. Really interested in what the authors have to say about this. |
Thanks for catching the issue. I confirm this observation in the attached This behavior might be introduced by version changes of the dependency libraries or typos within this repo; investigations on potential causes are very much appreciated. In the mean time, would it suffice if a post-processing step is implemented to correct the Cb atom positions for these residues, based on the ideal backbone geometry of standard AAs? Such hotfixes are also highly welcome. |
Not really sure how to create a pull request but the MODEL/ENDMDL wrap issue is simply solved by uncommenting line 348 in af_common/protein.py |
@Toverkwark, thanks for the heads up. I've made a PR on your behalf at #7. |
@abeebyekeen |
Description
If I run any prediction and load the resulting pdb into Maestro instead of pymol, the import doesn't recognize a full protein out of the pdbs. I think there are two problems that I've been able to sofar identify that are recurrent independent of what I model:
-The pdbs containing multiple models have the individual models not properly wrapped by MODEL and ENDMDL statements.
-The reason maestro seems to be unable to recognize a full protein seems to focus on particular amino acids, mostly those containing Cb substitutions, such as Threonine and Isoleucine and it occurred to me that at least for the threonines, all Cbs are modelled almost on top of the Cas. This probably means Maestro doesn't accept these to be bonded and therefore doesn't recognize the whole things as a contiguous protein.
What I Did
I simply ran the example command on the readme on github using any existing pdb as input as well as template.
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.
The text was updated successfully, but these errors were encountered: