Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlighting not triggered on command queue pop #40

Closed
sunaku opened this issue Jan 7, 2011 · 4 comments
Closed

highlighting not triggered on command queue pop #40

sunaku opened this issue Jan 7, 2011 · 4 comments

Comments

@sunaku
Copy link
Member

sunaku commented Jan 7, 2011

  1. Type in a command
  2. Press Alt-q to queue it
  3. Press Enter to pop the queued command
  4. Observe that popped command is not syntax highlighted
@danielshahaf
Copy link
Member

The command is popped from bufstack in zleread, which clears all highlighting as the last thing before returning. When zleread returns, control leaves the line editor and moves to inputline() (input.c:293) in the main shell. I suspect this will need to be fixed in the C code.

#0  zleread (lp=0x6dcd80 <prompt>, rp=0x6dcdb8 <rprompt>, flags=3, context=0, init=0x7ffff5e3fab8 "zle-line-init", 
    finish=0x7ffff5e3faa8 "zle-line-finish") at zle_main.c:1201
#1  0x00007ffff5e1bb41 in zle_main_entry (cmd=1, ap=0x7fffffffe2a0) at zle_main.c:1931
#2  0x000000000044e5ae in zleentry (cmd=1) at init.c:1523
#3  0x000000000044f46c in inputline () at input.c:293

@danielshahaf
Copy link
Member

Patch: workers/39432

@danielshahaf
Copy link
Member

Different patch committed upstream: zsh-users/zsh@5cf2ffb (workers/39452)

The fix requires both new zsh (current master, 5.3-to-be) and new z-sy-h (presumably due to #245).

@danielshahaf
Copy link
Member

Will be fixed by #245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants