Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't detach Strings from Pool<String> #86

Open
zslayton opened this issue May 27, 2015 · 0 comments
Open

Don't detach Strings from Pool<String> #86

zslayton opened this issue May 27, 2015 · 0 comments

Comments

@zslayton
Copy link
Owner

This was done to minimize refactoring required to release v0.10.0, which included auto-reconnect, reduced memory allocation and became usable from rustc's stable channel. However, the resulting code is a bit cluttered.

Instances of String in the Frame struct should be replaced with lifeguard's Recycled<String> type. This will allow all of the strings.attach(...) calls to be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant