-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock Alignment Control Needed #31
Comments
I did have a look at GravityBox's source code a few months back. However, I gave up after an hour since its codes are so messy.. |
Okay, will keep an eye out. I tried some other mods, and it seems there are multiple methods of centering the clock, and not all of them fix this. You might try contacting FemBlack and seeing if she is open to sharing the relevant bit of code. She credits another coder for some source code, so she might be willing to share one small chunk. If you can figure out why the format is Alignment-dependent, that would solve the bug aspect of this as well. |
@zst123 OmniROM has a feature which centers the clock. I can't be bothered digging through the code right now, just thought I'd tip you off in case you felt like working on this feature. I might give it a shot myself in the future. |
@Firefairy For example, I hooked only Clock.java, thus ClockCenter.java is not hooked. This is the same problem for multiple ROMs but with differing class names. (If I'm not wrong it was SlimROM JB that I saw the ClockCenter, but I'm recalling from memory now) @LumenTeun I have just looked at OmniROM's center clock feature and realized that GravityBox's version is easier to implement. OmniROM's one needed the status bar xml to be modified which is quite difficult in Xposed. omnirom/android_frameworks_base@970bcf5 |
This is somewhere between a feature request and a bug fix. If the Alignment of the clock is set to center using a non-Xposed setting, the custom format from Xui is lost. Using an Xposed module (in my case, XBlast) to also "change" the alignment to center fixes the problem, but most of the mods that include this feature are the large AIO conglomerations of features. Adding Alignment to Xui's options would be much preferable.
The text was updated successfully, but these errors were encountered: