Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shader parsing more future-proof #98

Closed
zturtleman opened this issue Aug 7, 2013 · 1 comment
Closed

Make shader parsing more future-proof #98

zturtleman opened this issue Aug 7, 2013 · 1 comment

Comments

@zturtleman
Copy link
Member

We should call SkipRestOfLine( ); after done parsing every line, similar to q3map2. So if keyword gets more (optional) args in the future, old spearmint won't blow up.

q3map2 ignores lines that start with an unknown keyword. Should the renderer do this too? It would make it easier to add new keywords later, but also means keyword typo will get ignored. Could add new #if keywords (example: #if ext_musicWaveform) to check if renderer supports a new feature instead.

@zturtleman zturtleman reopened this Dec 1, 2013
@zturtleman
Copy link
Member Author

Done in cef4cd1.

zturtleman added a commit that referenced this issue Jan 9, 2015
Windows header files for q3lcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant