Support specifying a build path when building images from a string #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeichle
force-pushed
the
docker_build_string_with_path
branch
from
bacbbd8
to
584f45a
Compare
valencar
approved these changes
Jun 30, 2017
|
Nice contribution! Thanks for sharing your work 😄 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds an option to
Dockerspec::Builder,string_build_path, which is used bybuild_from_stringto support specifying a build directory other than.The use case here is: test cases have directories with various fixtures/assets that need to be included in a build, and I want to be able to chain multiple builds together while also being able to access fixtures/assets during the build. To support this use case, I have an initial build performed (either via a string or a docker file)
images in the example group are built from a string that derives theFROMstatement using theDockerspec::Rspec::Resources#described_image` accessor.However, the later images cannot add the assets since currently building via the
Dockerspec::Rspec::Resources#docker_buildmethod does not allow specifying a path when building from a string, and instead defaults to.Issues Resolved
n/a
Contribution Check List
See CONTRIBUTING.md.