msglist: Fix channel header tap behaviour in multi-channel narrows

Set gesture detecter behavior of streamWidget to HitTestBehavior.opaque
to handle taps in empty space around the header.

Also added a test that checks if tapping empty space in channel header
area correctly navigates to the channel feed.

Fixes #1368.

Author: E-m-i-n-e-n-c-e

lib/widgets/message_list.dart

@@ -1083,6 +1083,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
         ?? zulipLocalizations.unknownChannelName; // TODO(log)
 
       streamWidget = GestureDetector(
+        behavior: HitTestBehavior.opaque,
         onTap: () => Navigator.push(context,
           MessageListPage.buildRoute(context: context,
             narrow: ChannelNarrow(message.streamId))),

test/widgets/message_list_test.dart

@@ -1470,4 +1470,113 @@ void main() {
         ..status.equals(AnimationStatus.dismissed);
     });
   });
+
+  group('channel header navigation in multi-channel narrows', () {
+      testWidgets("navigates to ChannelNarrow when tapping above or below stream name in recipient header", (tester) async {
+        final pushedRoutes = <Route<void>>[];
+        final navObserver = TestNavigatorObserver()
+          ..onPushed = (route, prevRoute) => pushedRoutes.add(route);
+        final channel = eg.stream();
+        final message = eg.streamMessage(stream: channel);
+        await setupMessageListPage(tester,
+          narrow: const CombinedFeedNarrow(),
+          streams: [channel],
+          subscriptions: [eg.subscription(channel)],
+          messages: [message],
+          navObservers: [navObserver]);
+
+        assert(pushedRoutes.length == 1);
+        pushedRoutes.clear();
+
+        connection.prepare(json: eg.newestGetMessagesResult(
+          foundOldest: true, messages: [message]).toJson());
+
+        // Find the recepient header rect
+        final recipientHeaderFinder = find.byType(StreamMessageRecipientHeader);
+        final recipientHeaderRect = tester.getRect(recipientHeaderFinder);
+
+
+        // Find the stream name text
+        final streamNameFinder = find.descendant(
+          of: recipientHeaderFinder,
+          matching: find.text(channel.name));
+        final streamNameRect = tester.getRect(streamNameFinder);
+
+        // First tap: 1 px below the top of recepient header at streamName x coordinate
+        await tester.tapAt(Offset(streamNameRect.center.dx, recipientHeaderRect.top + 1));
+
+        await tester.pump();
+        check(pushedRoutes).single.isA<WidgetRoute>().page.isA<MessageListPage>()
+          .initNarrow.equals(ChannelNarrow(channel.streamId));
+        await tester.pumpAndSettle();
+
+        // Navigate back to original page and clear routes
+        await tester.pageBack();
+        await tester.pumpAndSettle();
+        pushedRoutes.clear();
+
+        connection.prepare(json: eg.newestGetMessagesResult(
+          foundOldest: true, messages: [message]).toJson());
+
+        // Second tap: 1 px above the bottom of the recipient header at streamName x coordinate
+        await tester.tapAt(Offset(streamNameRect.center.dx, streamNameRect.bottom - 1));
+        await tester.pump();
+        check(pushedRoutes).single.isA<WidgetRoute>().page.isA<MessageListPage>()
+          .initNarrow.equals(ChannelNarrow(channel.streamId));
+        await tester.pumpAndSettle();
+      });
+
+      testWidgets("navigates to TopicNarrow when tapping above or below topic name in recipient header", (tester) async {
+        final pushedRoutes = <Route<void>>[];
+        final navObserver = TestNavigatorObserver()
+          ..onPushed = (route, prevRoute) => pushedRoutes.add(route);
+        final channel = eg.stream();
+        final message = eg.streamMessage(stream: channel, topic: 'testTopic');
+        await setupMessageListPage(tester,
+          narrow: const CombinedFeedNarrow(),
+          streams: [channel],
+          subscriptions: [eg.subscription(channel)],
+          messages: [message],
+          navObservers: [navObserver]);
+
+        assert(pushedRoutes.length == 1);
+        pushedRoutes.clear();
+
+        connection.prepare(json: eg.newestGetMessagesResult(
+          foundOldest: true, messages: [message]).toJson());
+
+        // Find the recepient header rect
+        final recipientHeaderFinder = find.byType(StreamMessageRecipientHeader);
+        final recipientHeaderRect = tester.getRect(recipientHeaderFinder);
+
+        // Find the topic name text
+        final topicNameFinder = find.descendant(
+          of: recipientHeaderFinder,
+          matching: find.text('testTopic'));
+        final topicNameRect = tester.getRect(topicNameFinder);
+
+        // First tap: 1 px below the top of recepient header at topicName x coordinate
+        await tester.tapAt(Offset(topicNameRect.center.dx, recipientHeaderRect.top + 1));
+        await tester.pump();
+        check(pushedRoutes).single.isA<WidgetRoute>().page.isA<MessageListPage>()
+          .initNarrow.equals(TopicNarrow(channel.streamId, message.topic));
+        await tester.pumpAndSettle();
+
+        // Navigate back to original page and clear routes
+        await tester.pageBack();
+        await tester.pumpAndSettle();
+        pushedRoutes.clear();
+
+        connection.prepare(json: eg.newestGetMessagesResult(
+          foundOldest: true, messages: [message]).toJson());
+
+        // Second tap: 1 px above the bottom of the recipient header at topicName x coordinate
+        await tester.tapAt(Offset(topicNameRect.center.dx, recipientHeaderRect.bottom - 1));
+        await tester.pump();
+        check(pushedRoutes).single.isA<WidgetRoute>().page.isA<MessageListPage>()
+          .initNarrow.equals(TopicNarrow(channel.streamId, message.topic));
+        await tester.pumpAndSettle();
+      });
+    }
+  );
 }