Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Tooltips at the top of the screen should open downward, out of device inset #1151

Open
chrisbobbe opened this issue Dec 13, 2024 · 2 comments
Labels
a-design Visual and UX design beta feedback Things beta users have specifically asked for upstream Would benefit from work in Flutter or another upstream
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 13, 2024

In beta feedback, a user reported that the "Channel feed" tooltip in the app bar of the topic-narrow message list was opening upward and getting hidden in the device inset:

On the right top side is "channel feed" button. If you are in portrait mode and long press it, description is overlaping with "notification area (signal indicator, battery stat....)". It's ok in landscape mode.

Here's how it looks on one device. The tooltip is still mostly visible here, but that won't always be the case. Some devices might cover up the tooltip with more things in that reserved space.

image

If opening a tooltip upward would put it in that reserved space at the top, we should open it downward instead.

@chrisbobbe chrisbobbe added a-design Visual and UX design beta feedback Things beta users have specifically asked for labels Dec 13, 2024
@Vardhan-ysh
Copy link

I want to work on this issue. Can I be assigned to this?

@gnprice
Copy link
Member

gnprice commented Dec 13, 2024

@Vardhan-ysh Welcome. See our guide to picking an issue to work on:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#picking-an-issue-to-work-on

I think this won't be a good issue for a contributor new to the project.

@gnprice gnprice added this to the M7: Future milestone Dec 13, 2024
@gnprice gnprice added the upstream Would benefit from work in Flutter or another upstream label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-design Visual and UX design beta feedback Things beta users have specifically asked for upstream Would benefit from work in Flutter or another upstream
Projects
Status: No status
Development

No branches or pull requests

3 participants