Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Build a better UI for choosing language #2611

Closed
gnprice opened this issue Jun 2, 2018 · 3 comments
Closed

settings: Build a better UI for choosing language #2611

gnprice opened this issue Jun 2, 2018 · 3 comments

Comments

@gnprice
Copy link
Member

gnprice commented Jun 2, 2018

This will be a bit complex to build, and I think right now we have a number of equally complex areas of UI work to do that will be higher-value. (Most users will only ever touch this screen either zero or one times.) But I'm getting down some thoughts now, since I was looking into this thanks to #2610.

Our screen for choosing the UI language looks like this:
image
Apart from some small layout issues (those are #2610) which shouldn't be hard to fix, there are a few problems with this:

  • It uses national (more or less) flags to represent languages. This is confused about the world (many languages are spoken widely in several countries, and many countries have several primary languages), and isn't super helpful anyway.
  • It names all the languages in English only.
  • It's a long list, in an unavoidably arbitrary order (it can't be in the order of the user's own language, because the point of the screen is we don't know that yet), with no search.

Good language selectors I see in mobile apps:

  • don't use flags
  • name each language in the current UI language, and in itself
  • provide a search box -- which searches through both those names for each language

The Wikipedia app (the official one from Wikimedia) does an excellent job of this. It's actually significantly different in details between their Android and iOS apps, but both are good models.

@anh2111htd
Copy link
Collaborator

@zulipbot claim

Hi, I am new to Zulip repo and looking for an issue to get started. This one looks doable. I'll follow Wikipedia's language screen on Android and make a WIP PR soon.

@anh2111htd
Copy link
Collaborator

The PR is ready for review.

@gnprice
Copy link
Member Author

gnprice commented Jan 5, 2019

Now done, with #3231. Thanks again @anh2111 !

@gnprice gnprice closed this as completed Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants