Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notch handling, with SafeAreaView #3064

Closed
borisyankov opened this issue Oct 19, 2018 · 3 comments
Closed

Fix notch handling, with SafeAreaView #3064

borisyankov opened this issue Oct 19, 2018 · 3 comments
Labels
a-layout duplicate Task closed to consolidate with an equivalent task.

Comments

@borisyankov
Copy link
Contributor

When iPhone X was released, new functionality to iOS was added to indicate safe area - to help with apps handling optional notches, rounded corners or the ...

A good article explaining all this here:
https://medium.com/rosberryapps/ios-safe-area-ca10e919526f

We started using a component react-native-safe-area to handle this.

It isn't working perfectly and we need to fix it.
Testing on iOS X or Simulator with it makes few layout issues obvious.

Better yet, use the now built-in component:
https://facebook.github.io/react-native/docs/safeareaview

@gnprice gnprice changed the title Replace react-native-safe-area with SafeAreaView Fix notch handling, with SafeAreaView Oct 22, 2018
@gnprice
Copy link
Member

gnprice commented Oct 22, 2018

@anirudhjain75 reports that on his Poco F1, Zulip leaves the bottom of the screen black:
image

From the web, this model appears to have an iPhone X-like notch, so possibly that's causing react-native-safe-area to get confused. Once we've made this change, we'll want to retest and see if that issue is resolved or if it should get separately filed and pursued.

@gnprice
Copy link
Member

gnprice commented Oct 23, 2018

(The Poco F1 issue is #3068 .)

@gnprice
Copy link
Member

gnprice commented Jun 6, 2019

It looks like we promptly duplicated this issue as #3066. There's more discussion there; closing in favor of that thread.

@gnprice gnprice closed this as completed Jun 6, 2019
@gnprice gnprice added the duplicate Task closed to consolidate with an equivalent task. label Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-layout duplicate Task closed to consolidate with an equivalent task.
Projects
None yet
Development

No branches or pull requests

2 participants