Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no obvious way to unmute a topic #3473

Closed
cyphase opened this issue May 5, 2019 · 5 comments
Closed

There's no obvious way to unmute a topic #3473

cyphase opened this issue May 5, 2019 · 5 comments
Labels
a-message list a-stream settings/subs Creating streams, subscribing, editing settings

Comments

@cyphase
Copy link

cyphase commented May 5, 2019

As far as I can tell, there's no way to unmute a topic in the mobile app. You can get to the muted topic from the stream's topic list, but not unmute it. If there is a way that I wasn't able to find, I think that makes this a valid issue anyway, since I looked all over the app and did some web searches trying to find a way to do it.

#267 and #415 are about adding mute/unmute, so this might be a regression.

Some possible, non-mutually-exclusive UIs for this:

  • Long pressing on the topic in the stream topic list to bring up a menu
  • A bar in the topic narrow like the unread messages bar
    • This topic is muted (Unmute topic)
  • A "Muted topics" UI, which exists in the web/desktop apps under Settings

CZO

EDIT (2020-05-26): Turns out there is a way to unmute a topic. You have to do a search that will return a message in the topic (you can search for the topic name), which gives you access to the topic recipient bar; then it's just a long-press and tap on "Unmute topic". That workaround doesn't invalidate this issue though.

@jainkuniya
Copy link
Member

I have worked on this long time back, #982
@gnprice let's decide the priority and continue on this

@gnprice
Copy link
Member

gnprice commented May 10, 2019

@cyphase Thanks for raising this! This would be a good feature to support, though I don't think it's a high priority (I don't think this is a super commonly-used feature.)

(I can't quite tell if we ever did support it -- looks like #982 wasn't merged, and I'm not sure if #415 covered this.)

I don't think we have a way to mute a topic either, so let's consider both of those together.

I think the main question we need to answer in order to implement it is, where should it appear in the UI? Thoughts in no particular order:

  • For unmuting, you don't naturally see the messages. (Though you can get to them from the stream's topic list if you want to.) So that pushes toward someplace like the stream's topic list.
  • OTOH the topic list is kind of a pain to get to if you're reading the topic and want to mute it.
  • I kind of like the banner. Do we currently show in any way that the topic you're looking at is muted, if it is? That'd be a good thing to do, and then it's natural to have the "unmute" action.
  • OTOH that doesn't lend itself to a corresponding way to mute the topic in the first place.

@gnprice gnprice added a-message list a-stream settings/subs Creating streams, subscribing, editing settings labels May 10, 2019
@cyphase
Copy link
Author

cyphase commented May 10, 2019

@gnprice

I don't think we have a way to mute a topic either, so let's consider both of those together.

You can mute a topic by long pressing on the topic header; which you can't see when narrowed to the topic, so you can only mute from a narrow that shows the header.

I kind of like the banner. Do we currently show in any way that the topic you're looking at is muted, if it is? That'd be a good thing to do, and then it's natural to have the "unmute" action.

Not in the banner; muted topics are grayed out in the stream's topic list. Streams do show a muted speaker icon in the banner when muted, but you can't unmute from there.

OTOH that doesn't lend itself to a corresponding way to mute the topic in the first place.

Maybe the current stream settings button (the circled 'i') could be topic specific when narrowed onto a topic? Right now it just shows the stream settings, even if you are narrowed into a topic.

@chrisbobbe
Copy link
Contributor

We've had another report of this, here.

@cyphase cyphase changed the title There's no way to unmute a topic There's no obvious way to unmute a topic May 27, 2020
@WesleyAC
Copy link
Contributor

Closing this now that #4568 and #4608 are merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-message list a-stream settings/subs Creating streams, subscribing, editing settings
Projects
None yet
Development

No branches or pull requests

5 participants