Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support swipe navigation between "Subscribed" and "All streams" #3997

Closed
harshbisle opened this issue Mar 22, 2020 · 4 comments · Fixed by #4249
Closed

Support swipe navigation between "Subscribed" and "All streams" #3997

harshbisle opened this issue Mar 22, 2020 · 4 comments · Fixed by #4249

Comments

@harshbisle
Copy link

Screenshot_20200316-122350
Add a feature to support the navigation between All streams and subscribed on swiping which makes it easier for users to switch between the both.

@jainkuniya
Copy link
Member

I am not sure, is this required or not. Because we have nested tabs, user might get confused.
We need to think over, which tabs needs this functionality.

old PR, focussing on the same. #3668

@rk-for-zulip rk-for-zulip changed the title Support : navigation between Subscribed and All streams on swiping. Support swipe navigation between "Subscribed" and "All streams" Mar 23, 2020
@gnprice
Copy link
Member

gnprice commented Mar 23, 2020

Thanks @harshbisle , and thanks @jainkuniya for that cross-reference!

Here's a previous chat discussion a few months ago.

I agree we should do this. It seems like we're consistently hearing that people expect swiping to work for that pair of top tabs; whereas for the bottom tabs (or "bottom navigation" -- as @ray-kraesig in that chat thread points out that Material Design, at least, reserves the name "tab" for the top kind) we don't hear that.

@gnprice
Copy link
Member

gnprice commented Mar 23, 2020

Looks like there's one other place we have top tabs (based on rg -i top.?tab), which is MessageReactionList (the screen you get to from "See who reacted" on long-press on a message.)

That one doesn't currently have swiping working either. We should enable swiping between tabs there too.

@harshbisle
Copy link
Author

Yes @gnprice we need to improve that part too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants