Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-navigation to v5 #4296

Closed
chrisbobbe opened this issue Nov 3, 2020 · 2 comments · Fixed by #4393
Closed

Upgrade react-navigation to v5 #4296

chrisbobbe opened this issue Nov 3, 2020 · 2 comments · Fixed by #4393
Assignees
@chrisbobbe
Labels
a-multi-org a-navigation dependencies Pull requests that update a dependency file P1 high-priority

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Nov 3, 2020 •
edited
Loading

Currently blocked by #3804, which has #4278 in progress. Done!

Release announcement: https://reactnavigation.org/blog/2020/02/06/react-navigation-5.0/

Upgrade guide: https://reactnavigation.org/docs/upgrading-from-4.x

Docs: https://reactnavigation.org/docs/getting-started
@chrisbobbe chrisbobbe added blocked on other work To come back to after another related PR, or some other task. dependencies Pull requests that update a dependency file a-navigation labels Nov 3, 2020
@chrisbobbe chrisbobbe self-assigned this Nov 3, 2020
@gnprice
Copy link
Member

gnprice commented Nov 3, 2020

(Mainly to help find this issue from these others: this follows #4248 for v4, #3649 for v3, and #3573 for v2.)

@chrisbobbe chrisbobbe mentioned this issue Nov 3, 2020
Merged
@chrisbobbe chrisbobbe removed the blocked on other work To come back to after another related PR, or some other task. label Dec 3, 2020
@chrisbobbe
Copy link
Contributor Author

chrisbobbe commented Dec 31, 2020 •
edited
Loading

Added the multi-org label, since I expect we'll want to settle into React Navigation v5 (which comes with a pretty big API change) before we make the necessary nav UI changes for better multi-org support. I think #4300 is fairly close, but I have posted a few questions there.

@chrisbobbe chrisbobbe mentioned this issue Jan 1, 2021
Closed
This was referenced Jan 7, 2021
Closed
Closed
@chrisbobbe chrisbobbe mentioned this issue Jan 11, 2021
Merged
This was referenced Jan 14, 2021
Merged
Closed
Merged
@chrisbobbe chrisbobbe mentioned this issue Jan 22, 2021
Merged
@chrisbobbe chrisbobbe mentioned this issue Aug 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-multi-org a-navigation dependencies Pull requests that update a dependency file P1 high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React Navigation v5 upgrade (part 2) chrisbobbe/zulip-mobile
2 participants
@gnprice @chrisbobbe