Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsScreen: Make rows consistent in having (or not having) an icon #5687

Closed
chrisbobbe opened this issue Mar 15, 2023 · 5 comments
Closed

Comments

@chrisbobbe
Copy link
Contributor

Currently, some rows in the settings screen have icons, and some don't. Probably we should either remove all the icons, or add icons for the rows that don't have them. Screenshot:

cc @terpimost @alya @gnprice

@saadkhan011
Copy link

Hi chrisbobbe,
I want to work on this issue can you assign me please.

@chrisbobbe
Copy link
Contributor Author

We haven't yet decided whether to keep or remove the icons, so this isn't yet ready to be worked on.

@saadkhan011
Copy link

oh okay no problem

@terpimost
Copy link

I don't think the current state of things is a problem. In the new redesign we will have icons but we also might not have them. That is ok:
image

@gnprice
Copy link
Member

gnprice commented Mar 31, 2023

Thanks @terpimost for the input. We'll leave this as is, then, until we get into implementing the redesign.

@gnprice gnprice closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants