Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "value notification" event has different identity #12

Closed
hufftheweevil opened this issue Jan 30, 2021 · 2 comments
Closed

New "value notification" event has different identity #12

hufftheweevil opened this issue Jan 30, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hufftheweevil
Copy link
Contributor

I see the update picks up on the new value notification event that was added with v6, and it just outputs on this node as a VALUE_UPDATED event. At first that seems to work fine, except the new value notification event uses a property called value, not newValue. (See docs) So when you receive a VALUE_UPDATED event, you need to figure out if it has a value or newValue property.

I propose that the value notification event should translate to a VALUE_NOTIFICATION event on the node, to ensure we handle the output message properly.

@hufftheweevil hufftheweevil added the bug Something isn't working label Jan 30, 2021
@marcus-j-davies
Copy link
Member

Agreed,

Initially, I wanted to try and keep the events simple in nature, but can see how 'too' simple that one is.

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Jan 30, 2021

I have pushed this out already (1.3.1)

I didn't want to be in the situation, where work arounds are deployed on various set ups, then we break it down the line with the new event. Wanted to catch it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants