Feature: Add DSK PIN to Control Panel and make searchable.

[billmoseley]

It would be handy to be able to search for a node by the PIN (or partial dsk) in the control panel,

Today I had three plugs of the same model that I wanted to repurpose. All had been previously included. I wanted to find out which node one of them was, so I did this to find he node ID:

$ fgrep 01388 *.jsonl
d20ebe47.jsonl:{"k":"node.46.dsk","v":"01388-22502-12546-62510-44349-18175-51032-23271"}

And then from that I could see its name, and then find it in Home Assistant.

The device(s) were not in the provisioning list, so couldn't look there.

[robertsLando]

Did you tried to do this from provisioning entries table?

[robertsLando]

in order to do this I have to add the pin the the node json, wondering if this makes then nodes.json sensitive when exporting and sending them

[AlCalzone]

I don't understand why that's necessary - all other dynamic values are also not stored in nodes.json.

[AlCalzone]

...that said, the DSK is the first half of the node's public key.

[billmoseley]

The DSK, and thus the PIN (first five digits), are already in .jsonl file, so I'm confused why it would be added to nodes.json.

{"k":"node.256.dsk","v":"45073-58123-57163-36426-58772-64649-25481-61172"}

I have to apologize for my lack of understanding, but what's the purpose of nodes.json? I thought it was to 1) be able to sync names and locations FROM (say) Home Assistant when migrating and 2) to store those names for display in ZUI Control Panel.

Updating the device's name in HA or ZUI doesn't change it in the other location that I can see.

I'm curious why the node's name and location are stored in the nodes.json file and not in the .jsonl file. Isn't the .jsonl file where the data about the nodes for a given controller are stored?

Speaking of curious, what's the reason for using the jsonl (and "k" and "v") format instead of just json?

I'll apologize once again as this isn't a huge need. I just thought that since the dsk is in the jsonl that searching it would not be a huge change. Like I said, grep is a reasonable tool... ;)

[AlCalzone]

Speaking of curious, what's the reason for using the jsonl (and "k" and "v") format instead of just json?

The jsonl files are a (mostly) append-only database, written line by line. So if the process crashes in the middle of a write, at most a few entries are missing or wrong. Writing the entire JSON file would create much more disk IO and is much more error prone.

I just thought that since the dsk is in the jsonl that searching it would not be a huge change.

It's not. It is available to applications as the node.dsk property, so this is just a matter of how and where to display it.