Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Sort RF regions alphabetically #3714

Closed
robertsLando opened this issue May 14, 2024 · 4 comments
Closed

[fix] Sort RF regions alphabetically #3714

robertsLando opened this issue May 14, 2024 · 4 comments

Comments

@robertsLando
Copy link
Member

I believe the regions are sorted by their raw integer values. It would probably make more sense for ZUI to sort them alphabetically.

Originally posted by @kpine in #3713 (reply in thread)

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Aug 13, 2024
@kpine
Copy link
Contributor

kpine commented Aug 13, 2024

Still nice to have.

@github-actions github-actions bot removed the Stale label Aug 14, 2024
@robertsLando
Copy link
Member Author

I have a feel I alteady did this just forgot to close/ref this issue. Could you check?

export const rfRegions = Object.keys(RFRegion)
.filter((k) => isNaN(k))
.map((key) => ({
text: key,
value: RFRegion[key],
}))
.sort((a, b) => a.text.localeCompare(b.text))
export const znifferRegions = Object.keys(ZnifferRegion)
.filter((k) => isNaN(k))
.map((key) => ({
text: key,
value: ZnifferRegion[key],
}))
.sort((a, b) => a.text.localeCompare(b.text))

@kpine
Copy link
Contributor

kpine commented Aug 14, 2024

Indeed you did. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants