Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bash completion does not work with the otp command #28

Open
ghost opened this issue Apr 14, 2017 · 13 comments · May be fixed by zx2c4/password-store#5
Open

Pass bash completion does not work with the otp command #28

ghost opened this issue Apr 14, 2017 · 13 comments · May be fixed by zx2c4/password-store#5

Comments

@ghost
Copy link

ghost commented Apr 14, 2017

Hi,

Pass bash completion does not work when using the otp command in Ubuntu (with other non pass-otp commands it does work).

I am using pass v1.7 and pass-otp v1.0.0.

Thanks

@tadfisher
Copy link
Owner

tadfisher commented Apr 14, 2017

I wouldn't expect it to work unless the completion function was extension-aware, and it's not.

I'd report this as a general issue to the pass mailing list, as there's nothing this project can do to enable completion without support from upstream.

@bexelbie
Copy link

bexelbie commented Nov 5, 2017

Could we modify the installation procedure to edit the bash completion information provided by upstream? It seems a sed of that file could get us the completion, unless we can get upstream to support generalized plugin completion somehow.

This would require us to do some level of integration testing against new versions of pass though in case this file changed and broke the sed.

@tadfisher
Copy link
Owner

No, I'm not going to modify files packaged by another application.

I'll work on generalizing completion in pass itself.

@innir
Copy link
Contributor

innir commented Mar 6, 2018

Just linking the corresponding issues of other extensions: roddhjav/pass-update#9 and palortoff/pass-extension-tail#4

@GFdevelop
Copy link

I'm vote for this iussue...pass-extension-tail have found a solution for this, see here https://github.com/palortoff/pass-extension-tail/blob/master/completion/pass-tail.bash.completion

@micah
Copy link

micah commented Apr 11, 2019

Hey @tadfisher !

I'm wondering if you made any progress in generalizing completion in pass as you mentioned last year in your comment?

The thing that drives me nuts with pass otp is the lack of tab completion!

@bexelbie
Copy link

Looks like the bash completion added in 1.7.3 needs to be updated as the extension method isn't working. I see a patch proposed from Feb 2 on the mailing list but no action, so I bumpted it.

@NilsIrl
Copy link

NilsIrl commented Mar 27, 2020

@tadfisher You haven't been active in a long time (in regards to pass-otp), what should we do going forward?

  • Give merge access to someone else? So that at least PRs can get through.?
  • Should we fork?

@bexelbie
Copy link

Perhaps we can add more committers @tadfisher ?

@heavyimage
Copy link

This is still broken I think? I'll source the otp completion manually for now but would be cool if this just worked!

@ghost
Copy link

ghost commented Apr 21, 2023

Is this task dead?

The bash completion is still missing in pass-otp...

@xundeenergie
Copy link

I've just created a pull-request for pass itself
zx2c4/password-store#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants