Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A brilliant - and also terrible - idea - for discussion only #67

Closed
softwarecreations opened this issue Aug 27, 2021 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@softwarecreations
Copy link

softwarecreations commented Aug 27, 2021

Why it's brilliant
Search the first n characters of the password on a search engine.
See how many results there are.
That can be like as one of the password scores. (the more results, lower the score)

Why it's terrible
The password will no longer be a secret if you send it to a search engine.
This is probably a showstopper for the idea.
You can limit the damage by only sending half of the password, or the first n words/tokens or whatever.

Inspired by the discussion in #63
The reason I came up with the idea. Is if someone uses a password like
maryhadalittlelambwhosfleecewaswhiteassnow
or whatever, it would likely return a billion search results, even though zxcvbn as is would probably think it's an amazing password.

@softwarecreations softwarecreations changed the title A brilliant and also terrible idea - for discussion only A brilliant - and also terrible - idea - for discussion only Aug 27, 2021
@MrWook MrWook added the enhancement New feature or request label Aug 27, 2021
@MrWook
Copy link
Collaborator

MrWook commented Aug 27, 2021

Like you wrote it yourself you can't just send a password to search engine xy. This is just a no go. The HaveIBeenPwned matcher is already kind of shady but in that implementation you hash the password and only send the first 5 chars of the hash to them.
But in general this is kind of covered by the common word and wikipedia dictionary.
An option would be to search for google search engine lists and include them as a dictionary.

But if someone really wanna get insulted by privacy advocates the person could build a custom matcher for the search engines :D.

@zxcvbn-ts zxcvbn-ts locked and limited conversation to collaborators Jul 18, 2022
@MrWook MrWook converted this issue into discussion #128 Jul 18, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants