Skip to content

Commit

Permalink
fix(livereload): wrong usage of reject, meant resolve. (#167)
Browse files Browse the repository at this point in the history
* fix(wkwebview): Images not loading in Ionic WKWebView

* fix(livereload): Images not loading

When running in an emulator or in a device with the flag --livereload images were not showing.

* lint(livereload): Updated for ihadeed comments

* fix(livereload): Using reject instead of resolve

Reject caused an error and did not return the URL. Fixed this resolving and returning the image URL back to the promise.
  • Loading branch information
eduardoRoth authored and ihadeed committed Jul 4, 2018
1 parent 70f8e21 commit bab73a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/providers/image-loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ export class ImageLoader {

// if we're running with livereload, ignore cache and call the resource from it's URL
if(this.isDevServer){
return reject();
return resolve(url);
}

// get file name
Expand Down

0 comments on commit bab73a8

Please sign in to comment.